Welcome!

[jstarkey]

Welcome to the new Code Critique forum. We've created this forum in the spirit of Open Source. One of the biggest advantages of OS is the fact that everyone can see the code. Having millions of eyes on the source means that just about any bug or exploit is going to be found in record time. It also helps the community grow, by sharing the "better ways" of doing things.

Please feel free to post your code here for others to offer suggestions and/or comments. Please also share the wealth by checking out someone else's work as well.

Enjoy!!

[n00854180t]

Cool forum idea ;)

[Merve]

I think that this forum is a great idea. It'll help me find the bugs in PEBoDMyAdmin in record time! And now...BuzzLY is a mod! Congrats BuzzLY!

I just found it a little weird when I signed into PHPBuilder, went to the EL, went back to the main page, and found a new forum, but it's all good because I'm sure that this forum is going to rock and we'll be running on ten pages in record time!

[planetsim]

This sounds like a great idea for all..

so to start things off


<?php
phpinfo();
?>


Can someone tell me how to improve that :D

[n00854180t]

LOL


<?php
phpinfo();
?>


Indent.

[Merve]

Actually, you wouldn't indent for that one. Usually...it's a matter of preference. It's so simple that there is absolutely no point in indenting.

[n00854180t]

I know. I was j/k.

[planetsim]

yay im a master at phpinfo(); Ok i guess there are more serious ones like Merve wants..

[jstarkey]

Originally posted by planetsim


<?php
phpinfo();
?>



You forgot to comment it. Remember, a year from now you may look at this and say "what was I thinking".

[n00854180t]

LOL good one.

[planetsim]

your so right hows this


<?php
//this page will say im so smart
//it will produce a whole gui look of the php.ini file
//my mates will think im some sort of genius when i show them
// that a little line of code can produce so much
phpinfo();

//remember its php as in the language
//info as information about it
// () for no particular reason other than it looks good
// ; to close it off
?>


I might not have said enough.

[jstarkey]

While that will suffice, it's generally a good idea to follow a standard convention. Might wanna check out something like PHPDoc:

http://pear.php.net/manual/en/package.php.php

:D

[LordShryku]

Bah! There's those "standards" again...

[drawmack]

actually you should turn php_info off on your server it gives a hacker too much information including your htaccess usernames and passwords.

[drawmack]

On a different note this is a great forum idea. I am working up my cv site and for it I am doing some downloadable php - mostly games and guestbooks and stuff. With this forum I can let the community test them out for me so I'm not embarassed by a stupid mistake that stops my code from executing on other people's servers.

thanks phpbuilder.

[Moonglobe]

Yes indeed, great idea! lol thats about all i have to say right now.....

[piersk]

Originally posted by drawmack
actually you should turn php_info off on your server it gives a hacker too much information including your htaccess usernames and passwords.

Or, you could do what I did (http://rover.diablog.co.uk/info.php) (although I can't take all the credit. I got the idea off John (http://www.phpbuilder.com/board/member.php?s=&action=getinfo&userid=1))

[jstarkey]

Originally posted by piersk
Or, you could do what I did (http://rover.diablog.co.uk/info.php) (although I can't take all the credit. I got the idea off John (http://www.phpbuilder.com/board/member.php?s=&action=getinfo&userid=1))

Copycat!! :mad:

:D

[piersk]

Hey! I credited you, both here and there (http://rover.diablog.co.uk/info.php).

[jayant]

but what if some error occurs and we need to debug:-



<?php
// note about the license in which the following is being
// dibtributed, other legal mumbo jumbo

// turn on all errors for better debugging
error_reporting(E_ALL);
// some comment
$debug_on = 1;
// some comment
if($debug_on==1) echo "about to enter function phpinfo";
// some comment
phpinfo();
// some comment
if($debug_on==1) echo "just exit from function phpinfo";

// end thanksgiving if any
?>

[n00854180t]

If you did that kind of thing for every line of code, a 10kb file would turn into a 100kb file very quickly.

[BuzzLY]

Originally posted by Merve
I think that this forum is a great idea. It'll help me find the bugs in PEBoDMyAdmin in record time! And now...BuzzLY is a mod! Congrats BuzzLY!

Thanks! I have been itching to use the ban button for ages now, and johnny's given me the go-ahead! Woo hoo! If any of you post crappy code, you're banned! :mad: :D

[LordShryku]

if($mod == "BuzzLy") {
run(&$hide);
}

[jstarkey]

Originally posted by BuzzLY
If any of you post crappy code, you're banned! :mad: :D

I knew you'd make a fine mod!! :D

[planetsim]

Originally posted by BuzzLY
Woo hoo! If any of you post crappy code, you're banned! :mad: :D

I guess thatd make me first. :p

[Merve]

Looks like I'm going to be banned pretty damn fast....

[Jeb.]

Originally posted by LordShryku
if($mod == "BuzzLy") {
run(&$hide);
}

Tsk tsk, didn't you know that calltime pass-by-reference has been deprecated? :D

BTW, brilliant idea with this forum jstarkey. I know I'm going to make some use out of it!

Piersk/John - I'd sure like to know how you did that. Mind sharing the secret? Or is it so obvious I should be kicking myself? ;)

[piersk]

Trade secret I'm afraid.

<incredibly geeky joke>If I told you, I'd have to kill you!</ekoj ykeeg ylbidercni>

Nah, all you do is run the phpinfo()-type script and then edit the html that is outputted.

Easy :D

<red neck>Now, where's ma gun, Bettsy</red neck>

[jstarkey]

Yes, I wouldn't advise doing it the purist way :D

[piersk]

It is possible to do it the long way round, but what would be the point (unless you're that board (geddit?)).

John, what happened to the PHPBuilder one?

[Jeb.]

Originally posted by piersk
Nah, all you do is run the phpinfo()-type script and then edit the html that is outputted.

Well, excuse me whilst I kick myself ;) Cheers for sharing :D

[piersk]

No probs. Now I'll just get my gun...

[laserlight]

hmm... what protocol would you use to send the bullets over the Internet?

[Moonglobe]

whatever it is i somehow think it'll go straight through Jeb's firewall.......

[piersk]

Muhahahahahahahaha

Who said anything about going over the internet. My "gun" is the kind that has disarmament treaties against it...

Muahahahahahahahahahahahahaha

[Merve]

This thread is starting to sound like the EL. Is there no such thing as OT in CC too?

[Moonglobe]

o i think their should be. we dont want you to start bumping here too!


yes i know that's weak coming from me...... but i have stopped and will not bump a topic in bad taste again. if i do jstarkey must decrememnet my post count by 100. agreed?:D


PS: i'm not kidding.....:)

[Merve]

Does your post count really matter that much?

[Moonglobe]

no..... but it was the only thing that i thought of that they could punish me with.....other suggestions are welcome.

[Merve]

using the LART, caging the PEBoD forever, temporary ban....

[LordShryku]

I'm thinking ban of the beaver would be good punishment... :D

[Moonglobe]

ok you guys are starting to scare me ;)

seriously i'd hate to be banned........ i love this community and i won't go away (unfortunately maybe but still:D).

[LordShryku]

Oh, you can stay. But the beaver hits the bricks :D

[Moonglobe]

well.....jusec.

include "incl/PEBoD.php5";
$beaver = new PEBoD();
$beaver->put_in_cage();
$beaver->cage->lock(mktime(0,0,0,12,31,2010));

that good enough?

[LordShryku]

LOL

[piersk]

Surely locking it away is not really a punishment. I think that maybe you should be locked in there with it

muahahahahahahahahahaha

(I'm quite liking these evil laughs.... maybe I should change my title. hmmmm)

[Jeb.]

Originally posted by piersk
No probs. Now I'll just get my gun...

Hmm, well, you gotta catch me first :p :D

Originally posted by Merve
This thread is starting to sound like the EL. Is there no such thing as OT in CC too?

Aww, c'mon. Every subforum has got to have at least one OT thread. ;)

[Merve]

Well a topic like 'Welcome' isn't much of a topic. :D

[piersk]

Originally posted by Jeb.
Hmm, well, you gotta catch me first :p :D

Well, I could use GeoIP...

[Merve]

Isn't that the thing they use to track hackers?

[Moonglobe]

well, yes, they could i suppose..... its just a database of which IPs belong to which countries basically.....

[Merve]

Norton Firewall uses it.

[Moonglobe]

yes well norton sucks.

[Merve]

Originally posted by Moonglobe
yes well norton sucks.

really? Coool...didn't know that...is there anything better out there....or do all firewalls sucks? Or does it suck because I use it:D?

[Moonglobe]

personally i dont use any anti-virus software and i get on just fine. Im a gamer, and they just cause too many problems. Plus im really cheap. IF i was goign to use anything, it'd be McAfee.