BuzzLY
10-02-2003, 02:04 AM
As always, please feel free to let me know if you think anything should be added, changed, or removed.
The Rules:
(aka "failure will result in a LARTing!"*)
Please only post finished code in this forum for which you would like to receive criticism. If your code isn't working, or is buggy, and you need help with it, take it to the Coding or General Help forum. Again, this is for complete code only. This doesn't mean it has to be a complete application -- the code simply needs to be in a completed state, without known bugs.
The Guidelines:
(aka "critiques in advance")
These are not the "rules" of the forum, but rather an attempt to come up with a few standards and guidelines. Feedback is appreciated as always. The Code Critique forum was created to allow you to show off your coding skills, and to request feedback from others. It is intended for complete code only. If you have code that you are having trouble with, and are looking for help, you have come to the wrong forum. In this case, please take your question to the appropriate forum (such as Coding (http://www.phpbuilder.com/board/forumdisplay.php?s=&forumid=10) or General Help (http://www.phpbuilder.com/board/forumdisplay.php?s=&forumid=2))
I know this is common sense, but we all make mistakes. Please remember to double check any code you post to make sure you've removed/changed any sensitive data like passwords, usernames, IP addresses, host names, etc.
It's on you if you post it. Please be careful.
When posting code, please comment it well, or at least describe in your post what the code is supposed to do. This forum is meant for critique and feedback, not for showing off how well you can obfuscate your code.
Whenever possible, keep your code snippets short -- include that which is necessary to demonstrate what you are trying to do, and want feedback on. If your code is excessively long (more than 50 lines), then please either attach it as a text file, or provide a link to a .phps file on your server. I suggest the .phps file, since it's easily updated, and can always reflect your latest version, rather than requiring you to upload a new file to phpbuilder.
Be sure to use the [ php] and [/php] tags around your code so that it is easier for us to read.
Indent your code properly -- if you want people to read it, make it easier to follow
PLEASE limit the width of your code so that it fits in the thread properly. Remember that PHP allows wrapping code to a new line in almost any situation -- that is why all lines must end with a semi-colon ( ; ):echo "Putting this
on several lines is
perfectly acceptable";
Don't take criticism personally. This forum is for critique, so just take it that way.
Don't be mean. When critiquing someone's work, remember that they put a lot of hard work into it so far. Be fair and objective ("you might think about doing it this way..."), not personal ("you are stupid if you think that...").
Remember that any suggestions you receive in this forum are just that -- suggestions. You and you alone are responsible for the final code you write. If someone convinces you to write code that ends up hacking the Pentagon, then you must take sole responsibility for that code. The bottom line: test, test, test!
As I said, please feel free to reply to this and suggest additions to these guidelines. Most of all... have fun. We're all here to learn from each other!
*Luser Attitude Readjustment Tool (http://en.wikipedia.org/wiki/LART)
The Rules:
(aka "failure will result in a LARTing!"*)
Please only post finished code in this forum for which you would like to receive criticism. If your code isn't working, or is buggy, and you need help with it, take it to the Coding or General Help forum. Again, this is for complete code only. This doesn't mean it has to be a complete application -- the code simply needs to be in a completed state, without known bugs.
The Guidelines:
(aka "critiques in advance")
These are not the "rules" of the forum, but rather an attempt to come up with a few standards and guidelines. Feedback is appreciated as always. The Code Critique forum was created to allow you to show off your coding skills, and to request feedback from others. It is intended for complete code only. If you have code that you are having trouble with, and are looking for help, you have come to the wrong forum. In this case, please take your question to the appropriate forum (such as Coding (http://www.phpbuilder.com/board/forumdisplay.php?s=&forumid=10) or General Help (http://www.phpbuilder.com/board/forumdisplay.php?s=&forumid=2))
I know this is common sense, but we all make mistakes. Please remember to double check any code you post to make sure you've removed/changed any sensitive data like passwords, usernames, IP addresses, host names, etc.
It's on you if you post it. Please be careful.
When posting code, please comment it well, or at least describe in your post what the code is supposed to do. This forum is meant for critique and feedback, not for showing off how well you can obfuscate your code.
Whenever possible, keep your code snippets short -- include that which is necessary to demonstrate what you are trying to do, and want feedback on. If your code is excessively long (more than 50 lines), then please either attach it as a text file, or provide a link to a .phps file on your server. I suggest the .phps file, since it's easily updated, and can always reflect your latest version, rather than requiring you to upload a new file to phpbuilder.
Be sure to use the [ php] and [/php] tags around your code so that it is easier for us to read.
Indent your code properly -- if you want people to read it, make it easier to follow
PLEASE limit the width of your code so that it fits in the thread properly. Remember that PHP allows wrapping code to a new line in almost any situation -- that is why all lines must end with a semi-colon ( ; ):echo "Putting this
on several lines is
perfectly acceptable";
Don't take criticism personally. This forum is for critique, so just take it that way.
Don't be mean. When critiquing someone's work, remember that they put a lot of hard work into it so far. Be fair and objective ("you might think about doing it this way..."), not personal ("you are stupid if you think that...").
Remember that any suggestions you receive in this forum are just that -- suggestions. You and you alone are responsible for the final code you write. If someone convinces you to write code that ends up hacking the Pentagon, then you must take sole responsibility for that code. The bottom line: test, test, test!
As I said, please feel free to reply to this and suggest additions to these guidelines. Most of all... have fun. We're all here to learn from each other!
*Luser Attitude Readjustment Tool (http://en.wikipedia.org/wiki/LART)