Welcome!

[jstarkey]

Welcome to the new Code Critique forum. We've created this forum in the spirit of Open Source. One of the biggest advantages of OS is the fact that everyone can see the code. Having millions of eyes on the source means that just about any bug or exploit is going to be found in record time. It also helps the community grow, by sharing the "better ways" of doing things.

Please feel free to post your code here for others to offer suggestions and/or comments. Please also share the wealth by checking out someone else's work as well.

Enjoy!!

[n00854180t]

Cool forum idea

[Merve]

I think that this forum is a great idea. It'll help me find the bugs in PEBoDMyAdmin in record time! And now...BuzzLY is a mod! Congrats BuzzLY!

I just found it a little weird when I signed into PHPBuilder, went to the EL, went back to the main page, and found a new forum, but it's all good because I'm sure that this forum is going to rock and we'll be running on ten pages in record time!

[planetsim]

This sounds like a great idea for all..

so to start things off

PHP Code:

<?php
phpinfo();
?>

Can someone tell me how to improve that

[n00854180t]

LOL

PHP Code:

<?php
    phpinfo();
?>

Indent.

[Merve]

Actually, you wouldn't indent for that one. Usually...it's a matter of preference. It's so simple that there is absolutely no point in indenting.

[n00854180t]

I know. I was j/k.

[planetsim]

yay im a master at phpinfo(); Ok i guess there are more serious ones like Merve wants..

[jstarkey]

Originally posted by planetsim

PHP Code:

<?php
phpinfo();
?>

You forgot to comment it. Remember, a year from now you may look at this and say "what was I thinking".

[n00854180t]

LOL good one.

[planetsim]

your so right hows this

PHP Code:

<?php
//this page will say im so smart
//it will produce a whole gui look of the php.ini file
//my mates will think im some sort of genius when i show them
//    that a little line of code can produce so much
phpinfo();

//remember its php as in the language
//info as information about it
// () for no particular reason other than it looks good
// ; to close it off
?>

I might not have said enough.

[jstarkey]

While that will suffice, it's generally a good idea to follow a standard convention. Might wanna check out something like PHPDoc:

http://pear.php.net/manual/en/package.php.php

[LordShryku]

Bah! There's those "standards" again...

[drawmack]

actually you should turn php_info off on your server it gives a hacker too much information including your htaccess usernames and passwords.

[drawmack]

On a different note this is a great forum idea. I am working up my cv site and for it I am doing some downloadable php - mostly games and guestbooks and stuff. With this forum I can let the community test them out for me so I'm not embarassed by a stupid mistake that stops my code from executing on other people's servers.

thanks phpbuilder.