To register for an Internet.com membership to receive newsletters and white papers, use the Register button ABOVE.
To participate in the message forums BELOW, click here
Code CritiqueHaving someone critique your code is always a great way to hone the skills. Stop in and post your code to see what your peers may have done differently.
They haven't really seen the light of day yet and I was wondering if any of you good folk would like to check them out and give me your expert opinions.
The shop thing took me about 4 or 5 weeks to write from scratch and the database took me about 3 weeks (but overall I think it's probably better than the shop).
Anyway, I'm sorry if this all seems like a cheap plug, but I've been coming to this forum for ages and this is the first time that I've ever really shown anyone my PHP scripts in action. I hope you don't mind.
I'll be sure to fix those spelling mistakes straight away (I haven't spell checked the site yet and I dread to think what other typos there are!).
By the way, I just ran a search and there are 28 vehicles from 95 to present that can do 100-150 mph (eg Merc Benz E Class, Land Rover, Nissan Pathfinder... etc. Are you sure you got that right? It seems to work ok from where I am.
Hmm, dunno what was up. I got 28 just now, but I'm in the house IE/Win XP.
Out in the barn, I'd played around a bit (FBSD/Mozilla 1.5) previous to that query; maybe one of the fields from a previous search was still "selected" when I punched that one up...
__________________
dalecosp ---------------- "God doesn't play dice." --- Albert Einstein
I hope so. You certainly gave me a bit of a fright there when you said nothing came up.
Anyway, thanks... and let me just say, I'm mega impressed with your eagle eyed spelling observations. Even after you told me about the mistakes, I was certain that critereon was the correct way to spell it. But I looked it up and it seems I was wrong!
__________________
"A proof is a proof. What kind of a proof? It's a proof. A proof is a proof. And when you have a good proof, it's because it's proven." -- Jean Chrétien
Well, I'll get a couple digs in beore the XHTML zealots come at you in full force
Some of your tags are overly outdated (see <font>). And the fact that there's no Doctype says that your not validating your code. You may want to plop a HTML 4.01 Transitional Doctype up there and run it through the validator. That shouldn't give you very much to have to fix.
Other than that, very nicely done. Aesthetically pleasing to say the least
Well sometimes when you already have a site up it is easier to check it with one of those rather than reading it over and over to make sure there are no spelling errors
Location: Rapid Offensive Unit "Foreign Object Damage"
Posts: 19,124
Quote:
Originally posted by jebster Well sometimes when you already have a site up it is easier to check it with one of those rather than reading it over and over to make sure there are no spelling errors
But will they tell you when you're using "principal" when you should be using "principle"?
__________________
On two occasions I have been asked [by Members of Parliament], "Pray, Mr. Babbage, if you put into the machine wrong figures, will the right answers come out?" I am not able rightly to apprehend the kind of confusion of ideas that could provoke such a question.
but can I just ask Lord Shy... what do you mean when you talk about tags being overly outdated??? And also, what do you mean when you say "the fact that there is no doctype proves I'm not validating my code"?
I genuinely don't know what you're talking about. I'd be very grateful if you could explain what you mean.
Couple of usability things...if I pick 10 of 1 item, then the basket only lets me remove all 10, perhaps I should be able to alter the quantity if I want to. Also if I pick another 10 of the same item, a new row gets inserted into the basket. Should the existing row be updated to 20 items?
Couldn't find any coding bugs, I noticed that the SQL search is properly escaped Didn't try high ascii chars though
By the way, in answer to all those screaming 'Validation'...show me a commonly used browser that properly implements the HTML 4.01 DTD The only good reason right now to validate your documents is in case you need to protect yourself from specification hijacking
but can I just ask Lord Shy... what do you mean when you talk about tags being overly outdated??? And also, what do you mean when you say "the fact that there is no doctype proves I'm not validating my code"?
I genuinely don't know what you're talking about. I'd be very grateful if you could explain what you mean.
jebster helped me out there with those links. The outdated part: some of the HTML tags you use, like font, are depreciated and near extinction. Something like that should be controlled in CSS. And the Doctype tells what kind of HTML is being used. It's usually the first line in the source. Right click - View Source here and you'll see the very first line is a HTML 4.01 Transitional DocType
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
Those are just the HTML standards. There's really no one telling you that you have to use them, but it does show that you take a little bit more pride in your work.
Linear Mode
