To register for an Internet.com membership to receive newsletters and white papers, use the Register button ABOVE.
To participate in the message forums BELOW, click here
PHPBuilder.com  
 

 

Go Back   PHPBuilder.com > PHP Help > Code Critique

Code Critique Having someone critique your code is always a great way to hone the skills. Stop in and post your code to see what your peers may have done differently.

Reply
 
Thread Tools Rate Thread Display Modes
Old 01-28-2004, 03:13 AM   #1
s_shrum
Í júst plây ønë øn TV
 
s_shrum's Avatar
 
Join Date: Feb 2003
Posts: 191
Looking to bullet-proof

I wrote this in like 3 hours with no knowledge of the 12-or-so functions that I used. It works, but will choke if various things are not in place.

Looking to bullet-proof it and maybe even tighten it up.

http://code.shrum.net/scripts/postfi.../postfiles.txt

TIA
__________________
Sêån Shrüm

Hømë: http://www.shrum.net
CATS: http://cats.shrum.net
Cødè: http://code.shrum.net
Cønsültìng: http://consulting.shrum.net
Bløg: http://blog.shrum.net
Møbløg: http://moblog.shrum.net

s_shrum is offline   Reply With Quote
Old 01-28-2004, 03:36 AM   #2
Moonglobe
Better fan than rebelo!
 
Moonglobe's Avatar
 
Join Date: Apr 2003
Location: brain://localhost:left-side
Posts: 2,381
for those massive echo statements you might try heredoc syntax (types.string at php.net). also, if you're running this through the CLI (as you should be) just use $argc and $argv, they're automatically registered as global by default in the CLI.
__________________
there's no place i can be, since i found serenity.
Moonglobe is offline   Reply With Quote
Reply

Bookmarks


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off
Forum Jump


All times are GMT -4. The time now is 12:56 PM.






Acceptable Use Policy

internet.comMediabistrojusttechjobs.comGraphics.com

WebMediaBrands Corporate Info


Advertise | Newsletters | Feedback | Submit News

Legal Notices | Licensing | Permissions | Privacy Policy


Powered by vBulletin® Version 3.7.2
Copyright ©2000 - 2009, Jelsoft Enterprises Ltd.