Re: [PHP-DEV] 3.0.6 show stopper From: Zeev Suraski (zeev <email protected>)
Date: 12/20/98

At 22:10 20/12/98, Zeev Suraski wrote:
>Woops, I didn't remove it, I moved it. Let me check it out.

Ok, I know why I moved it. Even though I can't see why it'd blow anything
up from first glance, you can move it back to where it was to see if it
helps. The idea is this - the memory limit is something that can be set in
the configuration file. Like every other cfg file directive, if it's not
found in the cfg file, it's given a default. However, there was a 'black
spot' between the time the memory manager was started (and used) and the
time the memory limit was initialized. In between that time, the memory
limit was garbage, usually 0, which was wrong. So, I did two things about
it - first, I initialized the memory limit right in the beginning of the
module_startup function, to a hardcoded 8MB that should be enough at the
very least until the real setting is read from the file. Second, in order
for this setting to take effect the least time until the actual value is
read from the cfg file, I moved the configuration file startup to the
beginning of the function as well.
As you can see, it'd be no big deal if you move it back.

Zeev

--
Zeev Suraski   <zeev <email protected>>
For a PGP public key, finger bourbon <email protected>

-- PHP Development Mailing List http://www.php.net/ To unsubscribe send an empty message to php-dev-unsubscribe <email protected> For help: php-dev-help <email protected>