[PHP-DEV] [mslifcak <<i>email protected</i>>: Re: 3.6.1: snmp_close frees community string passed to snmp_open] email protected>: Re: 3.6.1: snmp_close frees community string passed to snmp_open]",1); ?> From: Sascha Schumann (sascha <email protected>)
Date: 04/05/99

FYI 

-- 

          Regards,

                            Sascha Schumann | 
                                 Consultant | finger sas <email protected>
                                            | for PGP public key

attached mail follows:

Joe's fix works just fine. It will be included in the next release. Sorry for the inconvenience that NO_ZEROLENGTH_COMMUNITY may have caused.

-Mike Slifcak Internet Security Systems, Inc.

At 11:36 AM 4/5/99 -0400, Joe Marzot wrote: >sascha <email protected> writes: > >> UCD-SNMP version 3.6.1 bug report >> ---------------------------------------------------------- >> >> I'm one of the PHP3 developers and I'm currently trying to track down, if a >> SNMP related bug is on our side or on yours. >> >> We provide a simple way to get SNMP objects and as such need to open a session. >> We pass snmp_open() a pointer to a struct session which holds pointer to our >> private data. >> >> But, unless NO_ZEROLENGTH_COMMUNITY is defined at compile time, the pointer to >> the community string is only copied in snmp_sess_open() and freed afterwards in >> snmp_close(). >> >> There is no notice of this in the documentation and IMO a library should not >> free data it has not allocated. Are we missing something? >> >> Regards, >> >> Sascha Schumann > >looks like a bug to me. The current 3.6.1 code does the following >#ifdef NO_ZEROLENGTH_COMMUNITY > /* Fill in defaults if necessary */ > if (session->community_len != SNMP_DEFAULT_COMMUNITY_LEN){ > cp = (u_char *)malloc((unsigned)session->community_len); > if (cp) > memmove(cp, session->community, session->community_len); > } else { > session->community_len = strlen(DEFAULT_COMMUNITY); > cp = (u_char *)malloc((unsigned)session->community_len); > if (cp) > memmove(cp, DEFAULT_COMMUNITY, session->community_len); > } > > if (cp == NULL) { > snmp_errno = SNMPERR_GENERR; > in_session->s_snmp_errno = SNMPERR_GENERR; > snmp_sess_close(slp); > return(NULL); > } > > session->community = cp; /* replace pointer with pointer to new data */ >#endif /* NO_ZEROLENGTH_COMMUNITY */ > >perhaps something like this would be better > > /* Fill in defaults if necessary */ > if (session->community_len != SNMP_DEFAULT_COMMUNITY_LEN){ > cp = (u_char *)malloc((unsigned)session->community_len); > if (cp) > memmove(cp, session->community, session->community_len); > } else { >#ifdef NO_ZEROLENGTH_COMMUNITY > session->community_len = strlen(DEFAULT_COMMUNITY); > cp = (u_char *)malloc((unsigned)session->community_len); > if (cp) memmove(cp, DEFAULT_COMMUNITY, session->community_len); >#else > cp = strdup(""); >#endif > } > > if (cp == NULL) { > snmp_errno = SNMPERR_GENERR; > in_session->s_snmp_errno = SNMPERR_GENERR; > snmp_sess_close(slp); > return(NULL); > } > > session->community = cp; /* replace pointer with pointer to new data */ > >-GSM > >-- >G.S. Marzot email: gmarzot <email protected> >Nortel Networks voice: (978)916-3990 >600 Tech Park M/S BL60-101 pager: (800)409-6080 (4096080 <email protected>) >Billerica, MA 01821 fax: (978)670-8145 

--
PHP Development Mailing List   http://www.php.net/
To unsubscribe send an empty message to php-dev-unsubscribe <email protected>
For help: php-dev-help <email protected>