[PHP-DEV] [LONG] adding date/time to error_log, etc. From: Joey (joey <email protected>)
Date: 12/13/99

Sorry about the length, but please bear with me...

I have been working on a patch to main.c that would add date & time to the
error logs, and wanted to check a few things first...

1) Most modules seem to call php_error. Is there any particular reason
"php3_log_error" can't be moved to "php_log_error"? Does anyone know of a
particular place that calls php3_log_error directly? I looked in lxr,
and found some stuff in /standard/basic_functions.c...do we still use
that? Should it use php_error instead, maybe?

2) Would php3_log_error be the proper place to do this?

3) Is there any particular reason that we allocate

"FILE *log_file"

on line 291, even when in CGI? Should this be wrapped in

#if ! CGI_BINARY

and is there any reason to do so...(ie, it would seem that we would save
some storage, not sure how much?)

4) Any preferences to what format the date should be in? localtime?
gmtime? Any particular format? I was simply going to use apache's error
log format...or maybe this could be an ini setting? Perhaps using PHP's
date() formatting? Or am I trying to get too complex?

        --Joey Smith

Please forgive the long sig:

*** Notice To Bulk Emailers: Attention! Pursuant to US Code, Title 47,
Chapter 5, Subchapter II, 227, any & all unsolicited commercial e-mail
sent to this address is subject to a download and archival fee in the
amount of the $1500 US and copies will be forwarded to domain
administrators. Emailing denotes acceptance of said terms! 

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>