Date: 12/14/99
- Next message: keithhasson <email protected>: "[PHP-DEV] PHP 4.0 Bug #2975: This worked before 4.0b3 - Is it a problem with PHP4.0?"
- Previous message: Andrei Zmievski: "Re: [PHP-DEV] Proposed change to main.c"
- In reply to: Andrei Zmievski: "Re: [PHP-DEV] Proposed change to main.c"
- Next in thread: Sascha Schumann: "Re: [PHP-DEV] Proposed change to main.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
> Which compiler are you using? Declaring variables like this is bound to
> cause compatibility problems. emalloc() your storage instead.
>
>
> 3rd argument to strlcat() should be amount of free space left, not how
> many characters to copy.
>
> Have you tested all this?
>
> You might just want to send me the corrected patch and I'll add it after
> review along with the .ini option that controls this behavior.
>
> -Andrei
> * Ethernet n.: something used to catch the etherbunny. *
See, I /KNEW/ it couldn't be that easy...it compiles for me, and I used
error_log() to test it, and it works, but it just seemed to easy! :)
I'll send you the corrected patch later today...thanks for looking over it
for me.
-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe <email protected> For additional commands, e-mail: php-dev-help <email protected> To contact the list administrators, e-mail: php-list-admin <email protected>
- Next message: keithhasson <email protected>: "[PHP-DEV] PHP 4.0 Bug #2975: This worked before 4.0b3 - Is it a problem with PHP4.0?"
- Previous message: Andrei Zmievski: "Re: [PHP-DEV] Proposed change to main.c"
- In reply to: Andrei Zmievski: "Re: [PHP-DEV] Proposed change to main.c"
- Next in thread: Sascha Schumann: "Re: [PHP-DEV] Proposed change to main.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

