Re: [PHP-DEV] Re: Strange change From: Rasmus Lerdorf (rasmus <email protected>)
Date: 03/19/00

> On Mon, 20 Mar 2000, Rasmus Lerdorf wrote:
> > Andrei, could you explain your logic behind this patch?
> >
> > http://cvsweb.php.net/cvsweb.cgi/functions/exec.c.diff?r1=1.88&r2=1.89
> >
> > It is the reason something like:
> >
> > <?
> > echo exec("pwd");
> > ?>
> >
> > no longer prints anything.
>
> I don't know, your example prints everything fine for me. Those lines
> were removed because they were returning a buffer with undefined
> contents.

Well, it would return everything fine for you assuming you have
magic_quotes_runtime turned on. You removed the else clause that returns
the string in case magic_quotes_runtime is not turned on. That makes no
sense to me. If the buffer really is invalid, which my gdb trace does not
agree with, then both RETVAL_STRINGL() calls should have been
removed.

-Rasmus 

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>