Re: [PHP-DEV] Request for code-check From: Andi Gutmans (andi <email protected>)
Date: 08/10/00

I don't really have time to look at the whole thing but one thing caught my
eye.
You should change the function definition to force the pticket argument to
be sent by reference because we are trying to deprecate the fact that the
user sends with an &$foo as it is better if the pass-by-reference is
defined in the function decleration.
For example:
PHP_FE(getimagesize,second_args_force_ref)

Notice the second parameter.

Andi

At 01:40 AM 8/10/00 +0200, Troels Arvin wrote:
>I maintain a PHP extension which is not part of the main PHP
>distribution, primarily due to the fact that it's mostly interesting for
>Danish PHP developers (the extension clears transfers with a Danish
>banking system), i.e. a small fraction of the PHP community.
>
>Anyways:
>I have recently rewritten the extension, hoping that it now complies
>better the the Zend API.
>
>I hope that some experienced PHP programmers will take a few moments to
>run trough the cashcow.c (and php_cashcow.h) file and comment if there
>are things which ought to be done differently:
>
>http://troels.arvin.dk/beta/php-cashcow-1.3_4.0.1_1.1/
>
>Thanks in advance.
>
>
>BTW:
>Yes, I know that the extension's PHP functions should have been named
>cashcow_requestauth()/cashcow_requestcapture() in stead of just
>requestauth()/requestcapture(). But that's an old mistake which I don't
>want to reverse just now.
>
>--
>Greetings from Troels Arvin, Copenhagen, Denmark
>
>--
>PHP Development Mailing List <http://www.php.net/>
>To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
>For additional commands, e-mail: php-dev-help <email protected>
>To contact the list administrators, e-mail: php-list-admin <email protected> 

---
Andi Gutmans <andi <email protected>>
http://www.zend.com/

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>