Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mysql/libmysql mega-patch From: Andi Gutmans (andi <email protected>)
Date: 08/22/00

Monty,

I know I nagged about this patch but it came a few hours too late. 4.0.2
was already packaged and the current tree doesn't build with this change
anymore. It is best to postpone this to after 4.0.2 now.
Any idea how to easily revert to a previous CVS tag? I think PHP didn't
build for you because it just doesn't build now with your CVS commits.

Thanks,

Andi

At 15:09 22/08/00 +0300, Michael Widenius wrote:
>Hi!
>
> >>>>> "Stanislav" == Stanislav Malyshev <stas <email protected>> writes:
>
>SB> This "mega-patch" blew the Win32 build process. I'm not able to build
>SB> libmysql on Win32 - and therefore the build of php4ts.dll fails.
>SB>
>SB> During compilation I get 49 errors, all concerning the missing of
>SB> "raid.h".
>
>Sorry, that we missed that.
>
>The main problem was we wasn't able to compile PHP in our source tree
>(I hope Andy will help us solve that so that this doesn't happen again)
>
>Stanislav> That's mysql include file, not system file.
>
>I have now update raid.h to the CVS tree.
>
>SB>
>SB> Is "raid.h" available by default on other platforms? Or are those builds
>SB> now broken, also?
>SB>
>SB> Besides, I think the timing of this patch with the release of PHP 4.0.2
>SB> just around the corner is not good.
>
>Stanislav> Yes, I think if we would hold this until 4.0.2 is out that would be
>Stanislav> good. From what I understood from the comments, this is
>"feature" patch,
>Stanislav> not "bugfix" patch, and we are in sort of feature-freeze now...
>
>It's just an update of the MySQL client interface to 3.23.23; There
>is no critical bugs out in the old code so you can delay this a bit if
>you want.
>
>Stanislav> I guess this patch should be rolled back to php_4_0_2RC1 tag,
>and then
>Stanislav> re-applied after the release?
>
>Regards,
>Monty
>
>--
>PHP Development Mailing List <http://www.php.net/>
>To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
>For additional commands, e-mail: php-dev-help <email protected>
>To contact the list administrators, e-mail: php-list-admin <email protected> 

---
Andi Gutmans <andi <email protected>>
http://www.zend.com/

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>