Re: [PHP-DEV] zend_hash_add_or_update flaw From: Andi Gutmans (andi <email protected>)
Date: 12/06/00

At 09:50 PM 12/6/00 +0100, Sascha Schumann wrote:
> > Right. It doesn't work with unaligned data but did you actually bump into
> > such a case in PHP? I prefer not moving to memcpy() unless this is actually
> > the case.
>
> Yes (please refer to my first message). We are basically
> strtok'ing through a string and adding parts of that string
> to the hash.
>
> memcpy is often implemented as an inline function or even
> assembler by the C library, so the speed impact should be
> negligible.

OK, I didn't realize you are actually being bitten by this.
Go ahead and commit your patch.

Andi 

---
Andi Gutmans <andi <email protected>>
http://www.zend.com/

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>