Re: [PHP-DEV] Bug 8468 [Genrally 4.0.4pl1] From: Zak Greant (zak <email protected>)
Date: 01/03/01

James Moore wrote:
> Are we going to put all major and minor bug fixes in 4.0.4pl1 or just the
> bare necessity?

    Well, here was Zeev's message about 4.0.4pl1
    ========================================================================
    I want to release PHP 4.0.4pl1 early next week, or mid next week at the
    latest, after one RC round. (I'll prepare an RC as soon as toye/
    cvs.php.net comes back up). It will be based on the PHP 4.0.4 branch,
    with the following fixes being backported:

    - call_user_function_ex() related fixes (Thies - did you manage to get
    a clear understanding if everything is OK with the XML stuff now that
    the call_user_function_ex() problem is fixed?)

    - The 'php not parsing' bug has been reproduced by James Moore and
    Derick Rathens, and I got it fixed (I can't commit because toye is
    down). It occurs in servers with several vhosts, that have one or
    more of these vhosts set with engine=off. In addition, while
    fixing this bug I found additional cases in which similar things
    could happen (with different symptoms though, probably not revealing
    the PHP source code).

    If anybody can think of additional bugs that were fixed since 4.0.4
    and should be inside 4.0.4pl1, please let me know ASAP.
    ========================================================================

    The only response (AFAIK) was Anil saying that he would like the
    ext/mcrypt/config.m4 fix included in the patch release.

> I would personally say (mainly as its unlikly to be tested as much) that
> we should avoid as many Merge From Heads as much as possible and just put
> in Major bug fixes.
>
> For me these are the fixes Zeev made to mod_php4.c (the whole reason for
> pl1), the Solid fixes that dan commited earlier seem fairly important, im
> sure there are others too, but not the two detailed below IMHO.

    The simpler the patch release is, the better. :)

    On a related note, Dan was nice enough to procure the QA team a
    license for Solid. (Thanks Dan!)

    I can install Solid on my Mandrake box later this week. If I do this, I
    would be offering members of the QA and Dev team accounts for testing
    purposes.

    Alternately, is there a better way to do this - does the PHP group have
    a box that they could install Solid on and give the QA team access to?

> But what about other minor fixes, I think that we should really limit the
> changes made to pl1 so that we dont end up with pl2 cause someone added a
> bug fix that broke somthing else and the QA team didnt test. Maybe a way
> to ensure this happens is to ask people to fully justify why their
> patch/fix should go into the pl1 branch and leave it open for discussion
> on the php-dev list (this should be done before its commited). The reason
> im saying this is because its impossible to expect the QA Team to test
> everything thourghly and we know that 4.0.4 works well so lets not break
> it and get pl1 out quick.

    +1

    --zak

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>