[PHP-DEV] PHP 4.0 Bug #8573: Unnecessary Handle Allocation From: tcarroll <email protected>
Date: 01/06/01

From: tcarroll <email protected>
Operating system: Linux 2.2.18
PHP version: 4.0.4
PHP Bug Type: OCI8 related
Bug description: Unnecessary Handle Allocation

The following details a non-fatal bug. It results in a small memory-leak.
Within oci_execute(oci8.c), a
handle is allocated for OCIParam *param.

A call to OCIParamGet() follows in which
param is passed as an out variable. After the call,
param receives a new handle value. The original allocated handle was lost.

The call to OCIHandleAlloc() is unnecessary
and results in unrecoverable memory. A patch follows that
details the above said. It has been tested successfully.

--- oci8.c.orig Thu Nov 16 05:16:22 2000
+++ oci8.c Sat Jan 6 16:13:24 2001
@@ -1219,12 +1219,6 @@
                 statement->columns = emalloc(sizeof(HashTable));
                 zend_hash_init(statement->columns, 13, NULL, _oci_column_hash_dtor, 0);
                 
- OCIHandleAlloc(OCI(pEnv),
- (dvoid **)&param,
- OCI_DTYPE_PARAM,
- 0,
- NULL);
-
                 counter = 1;
 
                 statement->error =
@@ -1261,7 +1255,7 @@
                                                                            (dvoid *)statement->pStmt,
                                                                            OCI_HTYPE_STMT,
                                                                            statement->pError,
- (dvoid*)&param,
+ (dvoid**)&param,
                                                                            counter));
                         if (statement->error) {
                                 return 0; /* XXX we loose memory!!! */ 

-- 
Edit Bug report at: http://bugs.php.net/?id=8573&edit=1

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>