Re: [PHP-DEV] 4.0.6 From: Andi Gutmans (andi <email protected>)
Date: 05/08/01

Can you please check the latest CVS and let me know if the line numbers are
OK now? (when using \r as an end of line).
Thanks,

Andi

At 08:55 PM 5/8/2001 +0300, Andi Gutmans wrote:
>There is a problem with line numbers if you use "\r" as line endings. I
>will try and fix it before 4.0.6 (although after my last patch
>functionally "\r"'s will work which is the most important thing).
>
>Andi
>
>At 08:50 AM 5/8/2001 -0400, Dave Jones wrote:
>>>>it is not that odd because it may have treated it like whitespace - imagine
>>>>a long line script. now it may treat it not as whitespace and hence the
>>>>problem
>>>>
>>>>there is no big difference between whitespace and newline(s) in php, is it?
>>
>>>Both today (4.0.6-dev) and earlier \r is treated as whitespace.
>>>However, in previous versions including 4.0.5 and 4.0.4pl1 "\r" would
>>>not mark line endings such as end of // or # comments.
>>>So there is no way that I can think of that a script would have worked
>>>with 4.0.4pl1 and not with 4.0.5.
>>>Anyway, it doesn't really matter now because 4.0.6 should work.
>>
>>And also line number don't get incremented if there are no line ends, so
>>all syntax errors are reported as being on line 1.
>>
>>The issue might have never come up if the code used "r" mode for opens
>>rather that "rb", since the file are 'text' files. On platforms that
>>don't used embedded newline characters as the record delimiters, the
>>implementation of fread is responsible for mapping the underlying file
>>format to cannonical form (i.e. \n's delimiting lines).
>>
>>---------------------------------------------------------------------------
>>And also line number don't get incremented if there are no line ends, so
>>all syntax errors are reported as being on line 1.
>>
>>The issue might have never come up if the code used "r" mode for opens
>>rather that "rb", since the file are 'text' files. On platforms that
>>don't used embedded newline characters as the record delimiters, the
>>implementation of fread is responsible for mapping the underlying file
>>format to cannonical form (i.e. \n's delimiting lines).
>>
>>---------------------------------------------------------------------------
>>David L. Jones | Phone: (614) 292-6929
>>Ohio State Unviversity | Internet:
>>1971 Neil Ave. Rm. 406 | jonesd <email protected>
>>Columbus, OH 43210 | jones-d <email protected>
>
>
>--
>PHP Development Mailing List <http://www.php.net/>
>To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
>For additional commands, e-mail: php-dev-help <email protected>
>To contact the list administrators, e-mail: php-list-admin <email protected> 

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>