[PHP-DEV] Bug #12757 Updated: utf8_encode doesn't terminate strings with '\0' From: sniper <email protected>
Date: 08/15/01

ID: 12757
Updated by: sniper
Reported By: rnyberg <email protected>
Old Status: Open
Status: Feedback
Bug Type: Strings related
Operating System: any
PHP Version: 4.0.6
New Comment:

Could you add a short script that demonstrates what the bug is?

--Jani

Previous Comments:
------------------------------------------------------------------------

[2001-08-15 08:01:13] rnyberg <email protected>

It's fixed in one place, but it still doesn't set the trailing '\0'
if encoder == NULL, if I understand it correctly.

        -Richard

------------------------------------------------------------------------

[2001-08-15 05:44:25] sniper <email protected>

Seems like at least some of those have already been
fixed in CVS. Could you check the latest CVS snapshot:

http://snaps.php.net/

--Jani

------------------------------------------------------------------------

[2001-08-15 05:25:54] rnyberg <email protected>

The enclosed patch fixes the problem.

--- php-4.0.6/ext/xml/xml.c Thu May 24 14:42:12 2001
+++ php-rnyberg/ext/xml/xml.c Wed Aug 15 10:45:03 2001
@@ -494,14 +494,14 @@
        if (encoder == NULL) {
                /* If no encoder function was specified, return the data as-is.
                 */
- newbuf = emalloc(len);
- memcpy(newbuf, s, len);
+ newbuf = emalloc(len + 1);
+ memcpy(newbuf, s, len + 1);
                *newlen = len;
                return newbuf;
        }
        /* This is the theoretical max (will never get beyond len * 2 as long
         * as we are converting from single-byte characters, though) */
- newbuf = emalloc(len * 4);
+ newbuf = emalloc(len * 4 + 1);
        while (pos > 0) {
                c = encoder ? encoder((unsigned char)(*s)) : (unsigned short)(*s);
                if (c < 0x80) {
@@ -522,9 +522,10 @@
                pos--;
                s++;
     }
- if (*newlen < len * 4) {
- newbuf = erealloc(newbuf, *newlen);
+ if (*newlen < len * 4 + 1) {
+ newbuf = erealloc(newbuf, *newlen + 1);
        }
+ newbuf[*newlen] = '\0';
        return newbuf;
 }
 /* }}} */

------------------------------------------------------------------------

Edit this bug report at http://bugs.php.net/?id=12757&edit=1 

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>