Re: [PHP-DEV] Re: [PHP-CVS] Re: [PHP-DEV] ZEND_MODULE_API_NO in ZE2 [was Re: [PHP-CVS] cvs: php4 /ext/xmlrpc config.m4 /ext/xmlrpc/libxmlrpc acinclude.m4 xmlrpc.h xmlrpc.m4] From: Andi Gutmans (andi <email protected>)
Date: 09/27/01

At 09:19 AM 9/27/2001 +0100, James Moore wrote:
> > At 09:00 AM 9/27/2001 +0200, Markus Fischer wrote:
> > >On Wed, Sep 26, 2001 at 06:32:00PM -0500, Dan Libby wrote :
> > > > works for me. there is already an ifdef around the call that checks
>for
> > > > API version.
> > > >
> > > > I did find that it no longer links with the built-in expat due to
> > > > function redefines (php_XML_*), so I added an include of php_compat.h
>in
> > > > /ext/xml/expat/expat.h
> > >
> > >Yeah, lazy me I didn't take a look at myself. And I probably can
> > >think already what causes this: I was using the ZendEngine2.
> > >
> > >Shouldnt the ZEND_MODULE_API_NO in zend_modules.h also be bumped
> > >up for ZendEngine2; Zeev, Andi?
> >
> > I set it to todays date.
>
>do you think it would be woth calling it somthing different from ZE1 IE
>ZEND2_MODULE_API_NO or #define ZEND_VERSION_2 for nice easy preprocessing
>usage if someone is trying to make somthing compatible with ZE1 and ZE2.

We could define something in zend.h. ZEND_VERSION_2 or ZEND_ENGINE_2 or
something like that.

Andi 

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>