 |
 |
 |
 |
|
|
Date: 09/27/01
- Next message: Martin Jahn: "[PHP-DEV] Re: patch for design violation in SAPI.c"
- Previous message: Zeev Suraski: "[PHP-DEV] Re: [PATCH] patch for design violation in SAPI.c"
- In reply to: Stig Sæther Bakken: "[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/cpdf cpdf.c /ext/dba..."
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Thu, 27 Sep 2001, Stig Sæther Bakken wrote:
> ["Jeroen van Wolffelaar" <jeroen <email protected>>]
> > jeroen Tue Sep 25 18:48:46 2001 EDT
> >
> > Modified files:
> > /php4/ext/cpdf cpdf.c
> > /php4/ext/dba dba.c dba_db2.c dba_db3.c dba_dbm.c dba_gdbm.c
>
> Jeroen,
>
> Please don't "fix" things like this if you have no way to ensure that
> everything compiles _and_ works. Rather leave it up to each
> extension's maintainer to run the script, at least we're reasonably
> sure new bugs are not introduced.
I agree. At this point, it might be better to revert the whole patch.
-Andrei
The main reason Santa is so jolly is because he knows where
all the bad girls live. -- George Carlin
-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe <email protected> For additional commands, e-mail: php-dev-help <email protected> To contact the list administrators, e-mail: php-list-admin <email protected>
- Next message: Martin Jahn: "[PHP-DEV] Re: patch for design violation in SAPI.c"
- Previous message: Zeev Suraski: "[PHP-DEV] Re: [PATCH] patch for design violation in SAPI.c"
- In reply to: Stig Sæther Bakken: "[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/cpdf cpdf.c /ext/dba..."
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]