[PHP-DOC] #6513 [Opn->Csd]: get_browser() and register_globals From: philip <email protected>
Date: 12/30/02

 ID: 6513
 Updated by: philip <email protected>
 Reported By: stud1174 <email protected>
-Status: Open
+Status: Closed
 Bug Type: Documentation problem
 Operating System: all
-PHP Version: 4.3.0-RC2
+PHP Version: 4.3.0
 New Comment:

This is now documented, this problem exists prior to 4.0.6 and the diff
to php4 source can be seen here:

http://cvs.php.net/diff.php/php4/ext/standard/browscap.c?r1=1.42&r2=1.43

Doc changes can be seen here:

http://cvs.php.net/cvs.php/phpdoc/en/reference/misc/functions/get-browser.xml

Thank you for the report and making PHP better :)

Previous Comments:
------------------------------------------------------------------------

[2002-12-29 23:07:34] philip <email protected>

I'm leaving this open until someone can test with an older version, I
don't feel like it right now :) But, the docs are now register_globals
= off friendly.

------------------------------------------------------------------------

[2002-12-04 10:31:49] philip <email protected>

This is a doc problem, not a feature request. Not sure when this
behavior changed but I just tested and register_globals does not affect
get_browser() in PHP 4.3.0 but a user comment suggests this problem
existed as of 10-Jan-2002 so it needs to be researched.

a) When was this fixed? Document what it means.
b) Remove the $, and refer to $_SERVER in docs
c) If it turns out this wasn't fixed, reopen as a bug

------------------------------------------------------------------------

[2000-09-03 09:20:11] stud1174 <email protected>

I have a remark about the get_browser() function. When this function is
called without arguments it is supposed to use $HTTP_USER_AGENT for
argument. However if I use the
configuration directive
   register_globals = Off
then the variable $HTTP_USER_AGENT is not defined and get_browser()
returns an error. In this case I have to do the following
   $HTTP_USER_AGENT = getenv("HTTP_USER_AGENT");
   $browser = get_browser();
or alternatively
   $a = getenv("HTTP_USER_AGENT");
   $browser = get_browser($a);

I suggest that get_browser() function should act more cleverly in this
case and use getenv() to get the HTTP_USER_AGENT.

------------------------------------------------------------------------ 

-- 
Edit this bug report at http://bugs.php.net/?id=6513&edit=1

-- 
PHP Documentation Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php