[phplib-dev] cvs commit From: kir (phplib-dev <email protected>)
Date: 09/07/00

From: kir
Date: Thu Sep 7 17:56:09 2000
Modified files:
      php-lib/CHANGES
      php-lib/php/session/session3.inc
      php-lib/php/session/session4.inc

Log message:

  It is the fix for the bug that I added some time ago.
  ac_get_lock/ac_release_lock should use some additional
  information to lock session data, but they shouldn't lock
  session records in database.

Index: php-lib/CHANGES
diff -u php-lib/CHANGES:1.184 php-lib/CHANGES:1.185
--- php-lib/CHANGES:1.184 Mon Jul 24 03:48:38 2000
+++ php-lib/CHANGES Thu Sep 7 17:56:08 2000
@@ -1,4 +1,8 @@
-$Id: CHANGES,v 1.184 2000/07/24 01:48:38 ssilk Exp $
+$Id: CHANGES,v 1.185 2000/09/07 15:56:08 kir Exp $
+
+07-Sept-2000 kir
+ - Bugfix in session[34].inc, related to session data locking while
+ page processing.
 
 24-Jul-2000
   query_sql.inc:
Index: php-lib/php/session/session3.inc
diff -u php-lib/php/session/session3.inc:1.2 php-lib/php/session/session3.inc:1.3
--- php-lib/php/session/session3.inc:1.2 Fri Jun 30 18:16:11 2000
+++ php-lib/php/session/session3.inc Thu Sep 7 17:56:08 2000
@@ -5,7 +5,7 @@
  * Copyright (c) 1998,1999 NetUSE GmbH
  * Boris Erdmann, Kristian Koehntopp
  *
- * $Id: session3.inc,v 1.2 2000/06/30 16:16:11 kir Exp $
+ * $Id: session3.inc,v 1.3 2000/09/07 15:56:08 kir Exp $
  *
  */
 
@@ -355,11 +355,8 @@
       }
     }
     
- // We can't have session records locked and update them
- // in the same time. So first We have to release lock
- // and then store/update session data. [kir]
- $this->release_lock();
     $r = $this->that->ac_store($this->id, $this->name, $str);
+ $this->release_lock();
 
     if(!$r) $this->that->ac_halt("Session: freeze() failed.");
   }
Index: php-lib/php/session/session4.inc
diff -u php-lib/php/session/session4.inc:1.2 php-lib/php/session/session4.inc:1.3
--- php-lib/php/session/session4.inc:1.2 Fri Jun 30 18:16:11 2000
+++ php-lib/php/session/session4.inc Thu Sep 7 17:56:08 2000
@@ -5,7 +5,7 @@
  * Copyright (c) 1998,1999 NetUSE GmbH
  * Boris Erdmann, Kristian Koehntopp
  *
- * $Id: session4.inc,v 1.2 2000/06/30 16:16:11 kir Exp $
+ * $Id: session4.inc,v 1.3 2000/09/07 15:56:08 kir Exp $
  *
  */
 
@@ -355,11 +355,8 @@
       }
     }
     
- // We can't have session records locked and update them
- // in the same time. So first We have to release lock
- // and then store/update session data. [kir]
- $this->release_lock();
     $r = $this->that->ac_store($this->id, $this->name, $str);
+ $this->release_lock();
 
     if(!$r) $this->that->ac_halt("Session: freeze() failed.");
   }

---------------------------------------------------------------------
To unsubscribe, e-mail: phplib-dev-unsubscribe <email protected>
For additional commands, e-mail: phplib-dev-help <email protected>