Re: [phplib-dev] Re: [phplib] Re: [phplib-dev] Re: [phplib] How stable is PHPLib-Dev From: Jeroen Laarhoven (jeroen <email protected>)
Date: 09/27/00

Comments (asked for!) on teo's work and DEVELS-NOTE:

o What do you think, should we have class members for session name
  and ID, or to fetch them using session_*() funcs?

Since they are not changing during a session I guess vars should be oke.

o Should we add a constructor to call session->start() and fill this
  properties?

I am not sure about the constructor 'doing things', it might be called at
the wrong moment.

I would make start() filling the properties, since at that moment they're
known first.

o What about the other session_* functions. Should we extend this
  API to include such functionalties like cookie params and save handlers
  or should we think another session class?

No I wouldn't add these, since these are a lower level functions for
handling
and configuration of the session storage yourself. 

---

This might also be a good time to 'clean up' the sessions class.

I would make a clean new base class for new users/projects without all the
'romantic functions'. Then make a Session_BackComp or someting class
extending
this class and adding ALL these functions for compatibility with old code.
New projects: use the clean class, old code: use the compatible class.

API's:

Session:
 *  bool   start()
 *  string name ()
 *  string id ($sid = '')
 *  bool   register ($var_names)
 *  bool   is_registered ($var_name)
 *  bool   unregister ($var_names)
 *  bool   delete ()
 *  string get_hidden_session ()

Session_BackComp:
 *  string get_id ($sid = '')
 *  bool   put_id ()
 *  void   purl ($url)
 *  string pself_url ($url)
 *  void   hidden_session ()
 *  string get_hidden_id ()
 *  void   hidden_id ()

Not sure:
 # I am not sure query param handling should be a part of Session.
 # and this code is not perfect ... e.g. it does not replace a var if it is
 # already in the query.
 # (I made a query handling class and override the session functions using
this,
 # but this has at least one known problem still in it ...)
 # And there is --enable-trans-sid (I love it !!!) so I would say BackComp.
 *  string url ($url)
 *  string self_url ($url)
 *  string add_query ($qs = '',$qarray)
 *  void   padd_query ($qarray)
 # Do not see the use of these:
 *  string serialize ()
 *  bool   deserialize ()
 # And do not think these now have to be part of Session, maybe BackComp:
 *  void   reimport_get_vars ()
 *  void   reimport_post_vars ()
 *  void   reimport_cookie_vars ()
 *  void   reimport_any_vars ($arrayname)

---

Has anyone looked to user.inc yet?
Have these changes any inpact on that?

Greetings
Jeroen.

= = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
Jeroen Laarhoven, Zwolle, Netherlands
email: jeroen <email protected>
www: http://jeroen.polder.net
= = = = = = = = = = = = = = = = = = = = = = = = = = = = = =

---------------------------------------------------------------------
To unsubscribe, e-mail: phplib-dev-unsubscribe <email protected>
For additional commands, e-mail: phplib-dev-help <email protected>