[PHPLIB] Bugs in template and cart (7.2b) From: Stefan Ekman (stekman <email protected>)
Date: 03/30/00

Hi,

I have discovered the following 2 bugs: 

---
1. This is only a semibug, that is: It only matters in PHP4.0

Problem:

template::set_block() does not work in PHP4.0

Solution:

Line 109 in template.inc

is:

$str = preg_replace($reg,"{$name}", $str);

In PHP4.0 it must be:

$str = preg_replace($reg,"\{$name}", $str);

Reason:

That is that the { must be escaped, due to the new complex variable
handling, that use {}.
---

2. This is a real bug in cart.inc

Problem:

cart::show_empty_cart() is not called when showing with an empty cart
with cart::show_all()

Solution:

line 151:

if(!is_array($this->item)or $this->item==0)

Should be:

if(!is_array($this->item)or $this->num_items()==0)

Reason:

$this->item does not contain the number of items, it contains the items.

---

/Stefan Ekman

-
PHP3 Base Library Mailing List. Send messages to <phplib <email protected>>.
To unsubscribe, send "unsubscribe" to <phplib-request <email protected>> in
the body, not the subject, of your message.