Re[2]: [phplib] Problem with newly commited user4.inc From: Marko Kaening (marko <email protected>)
Date: 01/09/01

-----BEGIN PGP SIGNED MESSAGE-----

Hi Max,

> + $user->register('LFC'); if(!isset($LFC)) $LFC=new LFilterClass;
> It's logically wrong with User3. It's completely wrong with User4
> :) You should first instantiate an object, and then register it,
> shouldn't you?
Yes, you are right. Finally I learned that lesson. As you say, the
difference is that User3 wasn't so picky about that. It was wrong though.

> if (!isset($LFC)) {
> $LFC = new LFilterClass;
> $user->register('LFC');
> }
> MK> + if(!isset($EFC)) $EFC=new EFilterClass;
> MK> + if(!$user->is_registered('EFC')) $user->register('EFC');
> I guess both isset() and $user->is_registered() should work,
Well, I think both approaches should be identical? But maybe yours is
faster and it might be that the additional questioning with is_registered
is not really necessary, since I want to register it in any case.

> The class is compatible if the $user->register_globals is true.
Yeah.

> MK> environment already. Great!!!
> Good to hear it :)
;)

> The second way is a lot faster, I suppose 2 or more times, then the first,
Yes, logically. So it's good that you made this approach. Another
advantage over Brians approach to the PHP4 sessions.

> Don't think we should leave the format of the data compatible with the
> old PHPlib. It does not make sense. The data, of course, could be
Yes, exactly. There is no sense after all.

> That is not acceptable with the User class - it should have its own routines
> and data structures, not session's. It has now.
I see. That's the point I miss obviously.

OK, Max. Thanks for your help!

Good luck.

Bye,
Poka,
Marko

- --
                    O _ O
                     0 0
 ------------------m-\o/-m------------------------------------------
 Dr. Marko K"aning Tel/Fax: +49-3834 554 442 / -3834 554 301
 INP Greifswald email : kaening <email protected>

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: noconv
Comment: Made with pgp4pine 1.75

iQCVAwUBOlr921Cj8RO1d1z9AQFWGQP+OzpIk0PksrGGgwhK9KWajcpPNWL89sSl
zbkVEb+gZ8JKqvmU5F4GIKz3ohFBcfskIXcI0zKKXVGr37ji2D9bdK5+mmMHgz6K
TBlwGRbPkoxQ/sThd5c4J6J3ybYfXtOHgFgKkFPJuoDVcbINKV1Y4YHXnaLF/jxE
m3TkAMKYV3U=
=GTcq
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: phplib-unsubscribe <email protected>
For additional commands, e-mail: phplib-help <email protected>