[phplib] OOH Forms - Full of warnings / bugs? From: Adam Robertson (adam <email protected>)
Date: 03/13/01

Hi all,

I have just started messing about with the OOHForms class (from ,I believe,
the latest version 7.2c of PHPLib) and tried running it with
error_reporting(E_ALL) set.

I got a LOT of undefined index's,properties etc warnings which I would not
have expected from such a mature and well tested package.

I have set about fixing these (using ifset() etc), but was wondering if
anyone else had done this already to save me some work?

Also while doing so I noticed this at around line 648, top of the
add_element function:

 if ($t = $cv_tab[$el["type"]])
      $t = ("of_" . $t);
 else
      $t = ("of_" . $el["type"]);

does this look wrong to anyone else, to me it looks like it should have '=='
in the if?

Also around line 691, middle of the get_element function, there are tests
agains the $falg_nametranslation which looks a lot like a typo of
$flag_nametranslation defined earlier.

As I said earlier I have only been looking at the class for a few hours so
I'm kinda hoping someone will tell me why I'm wrong :)

Cheers,

Adam Robertson
Internet Developer

Random Media
14 South Audley Street
Mayfair
London W1K 1HN
t.+44 (0)20 7923 4298
f.+44 (0)20 7598 8826
www.randommedia.co.uk

---------------------------------------------------------------------
To unsubscribe, e-mail: phplib-unsubscribe <email protected>
For additional commands, e-mail: phplib-help <email protected>