Justtechjobs.com Find a programming school near you






Online Campus Both


php-developer-list | 2000111

Re: [PHP-DEV] CVS Account Request From: Zeev Suraski (zeev <email protected>)
Date: 11/15/00

At 02:22 16/11/2000, Jim Jagielski wrote:
>Source-level code is the core of QA. If you can't control or monitor
>the quality of the code coming in, then you can't monitor or
>control the quality of the final product. Security concerns in
>the code, or in patches applied to the code, is most definately
>a QA process. One way of ensuring this is a review-then-commit
>process, where a patch is submitted, reviewed and if approved
>commited. Well, maybe not "ensuring" it because it depends
>on how well it's "reviewed" and even when reviewed, interactions
>happen that cause problems. But it *does* increase the overall
>QA process. Also saying "just you 5 guys have commit access"
>does it as well. Not everyone who submits a patch needs CVS commit. :)
>CVS implies trust of the committer and responsibility of others
>to look over the patch.

I agree, and I think it's all a matter of finding the right mix. Saying
the bar should be as low as possible is wrong, but going to the other
extreme, where every patch has to be reviewed and accepted is also bad, and
will definitely hurt PHP's quick advancement. With the amount of code that
is going into PHP (which is generally a Good Thing), I think we have to be
realistic, and accept the fact that complete source-level QA is not going
to be possible. Right now there's no formalized source level QA, and the
PHP QA team is oriented towards functional testing only.

I think that setting the bar slightly higher, and maintaining ACL's, will
not hurt any legitimate submitters, and will reduce the likelihood of
illegitimate ones getting in.

Zeev 

--

Zeev Suraski   <zeev <email protected>>
CTO, Zend Technologies Ltd.  http://www.zend.com/

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>