Justtechjobs.com Find a programming school near you






Online Campus Both


php-developer-list | 2001122

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c From: Yasuo Ohgaki (yasuo_ohgaki <email protected>)
Date: 12/30/01

derick <email protected> wrote:

> On Sun, 30 Dec 2001, Yasuo Ohgaki wrote:
>
>
>>yohgaki Sat Dec 29 20:37:24 2001 EDT
>>
>> Modified files:
>> /php4/ext/session session.c
>> Log:
>> Get rid of error message
>> # These lines should be enabled when save handlers can be initialized
>> # before session module initialization.
>>
>
> I don't think it's a good idea to comment this. IMO, fix the issue first
> before disabling correct code. Please revert this.
>

Ok. No problem, since I totally agree with you :)
This patch closes some bug reports for mm save handler, though.

We have to decide what kind of solution for module dependency we adopt.
I can think of following solutions

1) "Start ini parser/module loader" that understand module dependency.
2) Change session module so that it does not require save
    handlers are loaded before.
3) Compile related module at once (i.e. Use #ifdef)
4) Make session module a normal module.
5) Others?

1) is hard to implement although I prefer 1).
This may have problem with 3rd party modules, so there should be
standard place/format to hold module dependency info.

2) is not hard, but requires more coding than 3).

3) requires only a few lines of changes. 3) is the easiest choice,
unless others have better/easier ideas. Anyone?

4) is probably not a good idea.

5) is open to everyone :)

I would like to solve session module problem with 3), if nobody
objects. 

--
Yasuo Ohgaki

> 
>>
>>Index: php4/ext/session/session.c
>>diff -u php4/ext/session/session.c:1.268 php4/ext/session/session.c:1.269
>>--- php4/ext/session/session.c:1.268	Tue Dec 25 20:55:54 2001
>>+++ php4/ext/session/session.c	Sat Dec 29 20:37:23 2001
>>@@ -17,7 +17,7 @@
>>    +----------------------------------------------------------------------+
>>  */
>>
>>-/* $Id: session.c,v 1.268 2001/12/26 01:55:54 yohgaki Exp $ */
>>+/* $Id: session.c,v 1.269 2001/12/30 01:37:23 yohgaki Exp $ */
>>
>> #ifdef HAVE_CONFIG_H
>> #include "config.h"
>>@@ -115,9 +115,12 @@
>> static PHP_INI_MH(OnUpdateSaveHandler)
>> {
>> 	PS(mod) = _php_find_ps_module(new_value TSRMLS_CC);
>>-	if(!PS(mod)) {
>>-		php_error(E_ERROR,"Cannot find save handler %s",new_value);
>>-	}
>>+/* Following lines are commented out to prevent bogus error message at
>>+   start up. i.e. Save handler modules are not initilzied before Session
>>+   module. */
>>+/*  	if(!PS(mod)) { */
>>+/*  		php_error(E_ERROR,"Cannot find save handler %s",new_value); */
>>+/*  	} */
>> 	return SUCCESS;
>> }
>>
>>
>>
>>
>>--
>>PHP CVS Mailing List (http://www.php.net/)
>>To unsubscribe, e-mail: php-cvs-unsubscribe <email protected>
>>For additional commands, e-mail: php-cvs-help <email protected>
>>To contact the list administrators, e-mail: php-list-admin <email protected>
>>
>>
> 
> 

-- 
Yasuo Ohgaki

_________________________________________________________
Do You Yahoo!?
Get your free  <email protected> address at http://mail.yahoo.com

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: php-dev-unsubscribe <email protected>
For additional commands, e-mail: php-dev-help <email protected>
To contact the list administrators, e-mail: php-list-admin <email protected>